delete stale @todo comments in LibFlow.flowERC1155#436
Conversation
Two `@todo` markers (safeBatchTransferFrom and per-transfer data) have been split out as tracked enhancements (#434, #435) so each can be evaluated separately. The source no longer carries the TODOs; both behaviours are spec-compliant under FlowV5. Closes #305. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 44 minutes and 29 seconds.Comment |
1 participant
Summary
LibFlow.flowERC1155carried two@todomarkers (safeBatchTransferFrom support,data support). Neither is a correctness defect under FlowV5 — per-transfer dispatch with emptydatais spec-compliant. Each marker is now split into its own tracked enhancement so they can be evaluated separately:The source no longer carries the TODOs; FlowV5 behaviour is final until either follow-up issue is decided.
Test plan
forge build— clean.rainix-sol-static— exit 0.Closes #305.
🤖 Generated with Claude Code